Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 24.04 2.4.2.1 Ensure at is restricted to authorized users #12711

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ericeberry
Copy link
Contributor

Description:

  • 2.4.2.1 Ensure at is restricted to authorized users

Rationale:

  • Implement 2.4.2.1 Ensure at is restricted to authorized users

@ericeberry ericeberry requested a review from a team as a code owner December 12, 2024 22:08
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 12, 2024
Copy link

openshift-ci bot commented Dec 12, 2024

Hi @ericeberry. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Dec 12, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.76 milestone Dec 12, 2024
Copy link

codeclimate bot commented Dec 12, 2024

Code Climate has analyzed commit 62527ea and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed

@@ -0,0 +1,35 @@
documentation_complete: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/etc/at.deny does not need to exist for this recommendation so this rule isn't needed


- file_at_deny_not_exist
- '!file_at_deny_exists'
- '!file_groupowner_at_deny'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should disable the at_deny rules, both files should be checked according to 2.4.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants